summaryrefslogtreecommitdiffstats
path: root/module/plugins
diff options
context:
space:
mode:
Diffstat (limited to 'module/plugins')
-rw-r--r--module/plugins/hooks/ExtractArchive.py23
-rw-r--r--module/plugins/internal/UnRar.py11
2 files changed, 19 insertions, 15 deletions
diff --git a/module/plugins/hooks/ExtractArchive.py b/module/plugins/hooks/ExtractArchive.py
index 47325608d..4756d359c 100644
--- a/module/plugins/hooks/ExtractArchive.py
+++ b/module/plugins/hooks/ExtractArchive.py
@@ -63,7 +63,10 @@ class ArchiveQueue(object):
def get(self):
- return self.plugin.getStorage("ExtractArchive:%s" % self.storage, "").decode('base64').split()
+ try:
+ return [int(pid) for pid in self.plugin.getStorage("ExtractArchive:%s" % self.storage, "").decode('base64').split()]
+ except Exception:
+ return []
def set(self, value):
@@ -103,7 +106,7 @@ class ArchiveQueue(object):
class ExtractArchive(Hook):
__name__ = "ExtractArchive"
__type__ = "hook"
- __version__ = "1.24"
+ __version__ = "1.25"
__config__ = [("activated" , "bool" , "Activated" , True ),
("fullpath" , "bool" , "Extract with full paths" , True ),
@@ -140,7 +143,7 @@ class ExtractArchive(Hook):
self.queue = ArchiveQueue(self, "Queue")
self.failed = ArchiveQueue(self, "Failed")
- self.interval = 300
+ self.interval = 60
self.extracting = False
self.extractors = []
self.passwords = []
@@ -276,16 +279,16 @@ class ExtractArchive(Hook):
for fname, fid in targets:
name = os.path.basename(fname)
- if not os.path.exists(fname):
- self.logDebug(name, "File not found")
- continue
-
pname = replace_patterns(fname, self.NAME_REPLACEMENTS)
if pname not in processed:
processed.append(pname) #: prevent extracting same file twice
else:
self.logDebug(name, "Skipped")
continue
+
+ if not os.path.exists(fname):
+ self.logDebug(name, "File not found")
+ continue
self.logInfo(name, _("Extract to: %s") % out)
try:
@@ -312,7 +315,7 @@ class ExtractArchive(Hook):
self.setPermissions(new_files)
for filename in new_files:
- file = fs_encode(filename)
+ file = fs_encode(save_join(filename, os.path.dirname(archive.filename)))
if not os.path.exists(file):
self.logDebug("New file %s does not exists" % filename)
continue
@@ -390,7 +393,7 @@ class ExtractArchive(Hook):
if not encrypted or not self.getConfig("usepasswordfile"):
archive.extract(password)
else:
- for pw in set(self.getPasswords(False) + [password]):
+ for pw in uniqify([password] + self.getPasswords(False)):
try:
self.logDebug("Try password: %s" % pw)
@@ -465,7 +468,7 @@ class ExtractArchive(Hook):
file = fs_encode(self.getConfig("passwordfile"))
with open(file) as f:
- for pw in f.read().splitlines()[:-1]:
+ for pw in f.read().splitlines():
passwords.append(pw)
except IOError, e:
diff --git a/module/plugins/internal/UnRar.py b/module/plugins/internal/UnRar.py
index c1cc0fa31..81cfb38a7 100644
--- a/module/plugins/internal/UnRar.py
+++ b/module/plugins/internal/UnRar.py
@@ -22,7 +22,7 @@ def renice(pid, value):
class UnRar(Extractor):
__name__ = "UnRar"
- __version__ = "1.09"
+ __version__ = "1.10"
__description__ = """Rar extractor plugin"""
__license__ = "GPLv3"
@@ -32,7 +32,8 @@ class UnRar(Extractor):
CMD = "unrar"
- EXTENSIONS = [".rar", ".zip", ".cab", ".arj", ".lzh", ".tar", ".gz", ".bz2",
+ # TODO: Find out what Filetypes Unrar supports exactly
+ EXTENSIONS = [".rar", ".cab", ".arj", ".lzh", ".tar", ".gz", ".bz2",
".ace", ".uue", ".jar", ".iso", ".7z", ".xz", ".z"]
#@NOTE: there are some more uncovered rar formats
@@ -40,7 +41,7 @@ class UnRar(Extractor):
re_rarpart2 = re.compile(r'\.r(\d+)$', re.I)
re_filefixed = re.compile(r'Building (.+)')
- re_filelist = re.compile(r'(.+)\s+(\d+)\s+(\d+)\s+|(.+)\s+(\d+)\s+\d\d-\d\d-\d\d\s+\d\d:\d\d\s+(.+)')
+ re_filelist = re.compile(r'(.+)\s+(\D+)\s+(\d+)\s+\d\d-\d\d-\d\d\s+\d\d:\d\d\s+(.+)')
re_wrongpwd = re.compile(r'password', re.I)
re_wrongcrc = re.compile(r'encrypted|damaged|CRC failed|checksum error', re.I)
@@ -166,7 +167,7 @@ class UnRar(Extractor):
try:
dir, name = os.path.split(self.filename)
- part = self.getattr(self, "re_rarpart%d" % i).search(name).group(1)
+ part = getattr(self, "re_rarpart%d" % i).search(name).group(1)
new_name = name[::-1].replace((".part%s.rar" % part)[::-1], ".part*.rar"[::-1], 1)[::-1]
file = fs_encode(os.path.join(dir, new_name))
@@ -220,7 +221,7 @@ class UnRar(Extractor):
# set a password
if "password" in kwargs and kwargs['password']:
- args.append("-p'%s'" % kwargs['password'])
+ args.append("-p%s" % kwargs['password'])
else:
args.append("-p-")